Hi Geert and Wolfram, Are you happy with this patch? Please let me know. Regards, Biju > Subject: RE: [PATCH] mmc: renesas_sdhi_internal_dmac: Add r8a774b1 > support > > Hi Geert, > > Thanks for the feedback. > > > Subject: Re: [PATCH] mmc: renesas_sdhi_internal_dmac: Add r8a774b1 > > support > > > > Hi Biju, > > > > On Thu, Sep 26, 2019 at 5:11 PM Biju Das <biju.das@xxxxxxxxxxxxxx> > wrote: > > > > Subject: Re: [PATCH] mmc: renesas_sdhi_internal_dmac: Add r8a774b1 > > > > support On Tue, Sep 24, 2019 at 8:49 AM Biju Das > > <biju.das@xxxxxxxxxxxxxx> wrote: > > > > > This patch adds SDHI support for RZ/G2N (R8A774B1) SoC. > > > > > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > > > --- > > > > > drivers/mmc/host/renesas_sdhi_internal_dmac.c | 1 + > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > diff --git a/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > > > > b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > > > > index 751fe91..7c6020e 100644 > > > > > --- a/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > > > > +++ b/drivers/mmc/host/renesas_sdhi_internal_dmac.c > > > > > @@ -308,6 +308,7 @@ static const struct soc_device_attribute > > > > soc_whitelist[] = { > > > > > .data = (void *)BIT(SDHI_INTERNAL_DMAC_ONE_RX_ONLY) }, > > > > > /* generic ones */ > > > > > { .soc_id = "r8a774a1" }, > > > > > + { .soc_id = "r8a774b1" }, > > > > > { .soc_id = "r8a774c0" }, > > > > > { .soc_id = "r8a77470" }, > > > > > { .soc_id = "r8a7795" }, > > > > > > > > Is this sufficient? > > > > Do you need a tuning quirk entry in sdhi_quirks_match[]? > > > > > > Do you mean the "quirks->manual_calibration" as mentioned in the > > > below > > patch ? > > > > > > https://patchwork.kernel.org/patch/11024131/ > > > > Exactly. Is RZ/G2N affected? > > No. RZ/G2N is not affected. I have enabled HS400 mode on RZ/G2N board > and without this patch it works fine. > > Note:- > I also tested with quirk entry added in sdhi_quirks_match. That is also works > fine. > > Regards, > Biju