Hi Kbuild test robot, On Wed, Oct 2, 2019 at 11:53 AM kbuild test robot <lkp@xxxxxxxxx> wrote: > I love your patch! Yet something to improve: > > [auto build test ERROR on tty/tty-testing] > [cannot apply to v5.4-rc1 next-20191001] Strange, this patch applies to all of v5.4-rc1, tty/tty-testing, and next-20191001? > url: https://github.com/0day-ci/linux/commits/Geert-Uytterhoeven/serial-sh-sci-Use-platform_get_irq_optional-for-optional-interrupts/20191002-171547 Oh, this is still the old tty/tty-testing before it was rebased to v5.4-rc1, i.e. still based on v5.3-rc4. That explains the build failure. That does not explain why you couldn't apply this patch to v5.4-rc1 and next-20191001, though. > base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing > config: sparc64-allmodconfig (attached as .config) > compiler: sparc64-linux-gcc (GCC) 7.4.0 > reproduce: > wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross > chmod +x ~/bin/make.cross > # save the attached .config to linux build tree > GCC_VERSION=7.4.0 make.cross ARCH=sparc64 > > If you fix the issue, kindly add following tag > Reported-by: kbuild test robot <lkp@xxxxxxxxx> > > All errors (new ones prefixed by >>): > > drivers/tty/serial/sh-sci.c: In function 'sci_init_single': > >> drivers/tty/serial/sh-sci.c:2899:24: error: implicit declaration of function 'platform_get_irq_optional'; did you mean 'platform_get_irq_byname'? [-Werror=implicit-function-declaration] > sci_port->irqs[i] = platform_get_irq_optional(dev, i); > ^~~~~~~~~~~~~~~~~~~~~~~~~ > platform_get_irq_byname > cc1: some warnings being treated as errors FTR, not reproducible on sparc on v5.4-rc1, current tty/tty-testing, and next-20191001. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds