Hi Biju,
Thank you for the patch.
On Tue, Oct 01, 2019 at 01:15:17PM +0100, Biju Das wrote:
> RZ/G2N board is pin compatible with RZ/G2M board. However on the SoC
> side RZ/G2N uses DU3 where as RZ/G2M uses DU2 for the DPAD. In order to
> reuse the common dtsi for both the boards, it is required to move du clock
> properties from common dtsi to board specific dts.
>
> Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
It would be nice if DT had a syntax that allowed extending an existing
property. It would allow us to write
&du {
clocks += <&versaclock5 1>,
<&x302_clk>,
<&versaclock5 2>;
clock-names += "dclkin.0", "dclkin.1", "dclkin.2";
};
in hihope-common.dtsi and be done with it.
Rob, do you think that's something worth adding ?
In any case, until we have that, this patch looks good to me.
Reviewed-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/renesas/hihope-common.dtsi | 8 --------
> arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts | 11 +++++++++++
> 2 files changed, 11 insertions(+), 8 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> index 3e376d2..355d0a2 100644
> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> @@ -142,14 +142,6 @@
> };
>
> &du {
> - clocks = <&cpg CPG_MOD 724>,
> - <&cpg CPG_MOD 723>,
> - <&cpg CPG_MOD 722>,
> - <&versaclock5 1>,
> - <&x302_clk>,
> - <&versaclock5 2>;
> - clock-names = "du.0", "du.1", "du.2",
> - "dclkin.0", "dclkin.1", "dclkin.2";
> status = "okay";
> };
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> index 93ca973..96f2fb0 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m.dts
> @@ -24,3 +24,14 @@
> reg = <0x6 0x00000000 0x0 0x80000000>;
> };
> };
> +
> +&du {
> + clocks = <&cpg CPG_MOD 724>,
> + <&cpg CPG_MOD 723>,
> + <&cpg CPG_MOD 722>,
> + <&versaclock5 1>,
> + <&x302_clk>,
> + <&versaclock5 2>;
> + clock-names = "du.0", "du.1", "du.2",
> + "dclkin.0", "dclkin.1", "dclkin.2";
> +};
--
Regards,
Laurent Pinchart
