Hi Sergei, On 12/09/2019 11:26, Kieran Bingham wrote: > Hi Sergei, > > (pulling in +Geert for his opinion on compatible string usages) > > On 12/09/2019 11:00, Sergei Shtylyov wrote:> Hello! >> >> On 11.09.2019 22:25, Kieran Bingham wrote: >> >>> Add direct support for the r8a77980 (V3H). >>> >>> The V3H shares a common, compatible configuration with the r8a77970 >>> (V3M) so that device info structure is reused. >> >> Do we really need to add yet another compatible in this case? >> I just added r8a77970 to the compatible prop in the r8a77980 DT. That's why >> a patch like this one didn't get posted by me. Also, the documentation at : Documentation/devicetree/bindings/display/renesas,du.txt already states the the "renesas,du-r8a77980" compatible string is supported thanks to [0], so actually - this addition is a requirement to make the driver match the documentation. [0] 4ffe5aa53791 ("dt-bindings: display: renesas: du: document R8A77980 bindings") >>> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx> >> [...] >> >> MBR, Sergei >