Hello Shimoda-san, On Thu, Sep 05, 2019 at 11:07:02AM +0000, Yoshihiro Shimoda wrote: > Hi Veeraiyan, > > > From: Veeraiyan Chidambaram, Sent: Thursday, September 5, 2019 6:18 PM > > > > In R-Car Gen3 USB 3.0 Function, if host is detached an interrupt > > will be generated and Suspended state bit is set in interrupt status > > register. Interrupt handler will call driver->suspend(composite_suspend) > > if suspended state bit is set. composite_suspend will call > > ffs_func_suspend which will post FUNCTIONFS_SUSPEND and will be consumed > > by user space application via /dev/ep0. > > > > To be able to detect the host detach, USB_INT_1_B2_SPND to cover the > > Suspended bit of the B2_SPND_OUT[9] from the USB Status Register > > (USB_STA) register and perform appropriate action in the > > usb3_irq_epc_int_1 function. > > > > Without this commit, disconnection of the phone from R-Car H3 ES2.0 > > Salvator-X CN11 port is not recognized and reverse role switch does > > not happen. If phone is connected again it does not enumerate. > > > > With this commit, disconnection will be recognized and reverse role > > switch will happen by a user space application. If phone is connected > > again it will enumerate properly and will become visible in the > > output of 'lsusb'. > > > > Signed-off-by: Veeraiyan Chidambaram <veeraiyan.chidambaram@xxxxxxxxxxxx> > > Thank you for the patch! > > Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > And, I tested this patch on my environment [1] and works correctly. So, > > Tested-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> I guess there are strong similarities between this patch and [3]. Would you like to pick [1-3], as they still apply cleanly to vanilla? [1] https://patchwork.kernel.org/patch/10581479/ ("[1/3] usb: renesas_usbhs: simplify usbhs_status_get_device_state()") [2] https://patchwork.kernel.org/patch/10581485/ ("[2/3] usb: renesas_usbhs: enable DVSE interrupt") [3] https://patchwork.kernel.org/patch/10581489/ ("usb: renesas_usbhs: add suspend event support in gadget mode") PS: Apologize for long silence in [3]. -- Best Regards, Eugeniu.
