Hi Simon, On Wed, Aug 21, 2019 at 10:17:48AM +0200, Simon Horman wrote: > On Tue, Aug 20, 2019 at 05:19:30PM +0200, Simon Horman wrote: > > On Tue, Aug 20, 2019 at 11:52:05AM +0200, Jacopo Mondi wrote: > > > Hi Simon, > > > > > > On Mon, Aug 19, 2019 at 04:05:44PM +0200, Simon Horman wrote: > > > > Renesas media binding documentation files uses a naming schema of > > > > 'renesas,<module>.txt'. Rename the SH Mobile CEU file to match this pattern. > > > > > > > > > > The old soc-camera based sh-mobile-ceu driver has been removed one > > > year ago and replaced by driver/media/platform/renesas-ceu.c whose > > > bindings are described at > > > Documentation/devicetree/bindings/media/renesas,ceu.txt > > > > > > Should this file be removed instead of renamed? > > > > Thanks, > > > > I thought I had checked that but clearly I did not. > > I agree the file should be removed and I'll send a revised patch > > accordingly. > > The one lingering reference to renesas,sh-mobile-ceu I can see > in the tree is its use in an example of two data pipelines in > Documentation/devicetree/bindings/media/video-interfaces.txt > Yeah, I noticed that, but never considered it more than an example. Although, with the removal of the bindings description, it should probably be changed to avoid generating confusion... > Could you suggest an alternative example? The pipeline described in the example is purely fictional, as it uses a "renesas-shmobile-csi2" compatible to model a CSI-2 input which I don't see mentioned anywhere. I guess the CEU compatible value there could be changed to anything we want, including the new renesas-ceu value which has superseded the sh-mobile-ceu one. Otherwise, RZ/A2 supports both CSI-2 by using the rcar-vin+rcar-csi2 IP blocks we have in R-Car and parallel input using the old CEU interface. We could use that as a real-world example, using VIN for CSI-2 and CEU for parallel input. Unfortunately, no RZ/A2 DTS in mainline has any of the two interfaces enabled afaict. I'll send a patch to the media list that just changes the suppressed compatible value with the new 'renesas-ceu' one unless someone has different opinions. Thanks j
Attachment:
signature.asc
Description: PGP signature
