On Wed, Aug 21, 2019 at 10:57 AM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, Aug 19, 2019 at 09:56:18PM +0900, Yoshihiro Kaneko wrote: > > Sort nodes. > > > > If node address is present > > * Sort by node address, grouping all nodes with the same compat string > > and sorting the group alphabetically. > > Else > > * Sort alphabetically > > > > This should not have any run-time effect. > > > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v5.4. > Sorry, I feel that I have missed this in other review's too, > but, isn't canfd out of order. Its bus address seems to place it > before dmac0. Or do we prefer to keep it grouped with the can nodes? We always group it with the can nodes. BTW, i2c_dvfs is similar, but it seems we deviated from that in at least one case. Once the nodes are sorted, we can run my soc-dts-diff script and fix the last small deviations, crickets, and typos. > The above notwithstanding, > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Thanks! Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds