On Wed, Aug 07, 2019 at 08:13:27PM +0200, Daniel Lezcano wrote: > On 07/08/2019 10:46, Geert Uytterhoeven wrote: > > Fix various issues in the error path of ostm_init(): > > 1. Drop error message printing on of_iomap() failure, as the memory > > allocation core already takes of that, > > 2. Handle irq_of_parse_and_map() failures correctly: it returns > > unsigned int, hence make irq unsigned int, and zero is an error, > > 3. Propagate/return appropriate error codes instead of -EFAULT. > > 4. Add a missing clk_put(), > > 5. Split the single cleanup block in separate phases, to avoid > > clk_put() calling WARN() when passed an error pointer. > > Does it make sense to convert to timer-of API? I don't have an opinion on that at this time, but as an improvement this patch looks good to me. Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
