Thanks, applied and queued for v5.4.On Thu, Aug 15, 2019 at 8:14 AM Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> wrote: > The local variable np in function rcar_sysc_pd_init takes the return > value of of_find_matching_node_and_match, which gets a node but does not > put it. If np is not put before the function returns, it may cause a > memory leak. Hence, remove the return statement that does not > immediately follow a putting of np. Replace it with a goto pointing to a > pre-existing label that first puts np and then returns the required > value. > Issue found with Coccinelle. > > Signed-off-by: Nishka Dasgupta <nishkadg.linux@xxxxxxxxx> Fixes: afa6f53df6052968 ("soc: renesas: rcar-sysc: Add support for fixing up power area tables") Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> i.e. will queue in renesas-devel for v5.4. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds