Use the devm_add_action_or_reset() helper instead of open-coding the same operations. Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> --- drivers/thermal/rcar_gen3_thermal.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/thermal/rcar_gen3_thermal.c b/drivers/thermal/rcar_gen3_thermal.c index a56463308694e937..2db7e7f8baf939fd 100644 --- a/drivers/thermal/rcar_gen3_thermal.c +++ b/drivers/thermal/rcar_gen3_thermal.c @@ -443,11 +443,10 @@ static int rcar_gen3_thermal_probe(struct platform_device *pdev) if (ret) goto error_unregister; - ret = devm_add_action(dev, rcar_gen3_hwmon_action, zone); - if (ret) { - rcar_gen3_hwmon_action(zone); + ret = devm_add_action_or_reset(dev, rcar_gen3_hwmon_action, + zone); + if (ret) goto error_unregister; - } ret = of_thermal_get_ntrips(tsc->zone); if (ret < 0) -- 2.17.1