Hi Biju, On Fri, Jul 5, 2019 at 12:20 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote: > Enable PCA9654 GPIO expander, so that we can configure its GPIOs later. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi > +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi > @@ -162,6 +162,13 @@ > clock-frequency = <400000>; > status = "okay"; > > + gpio_expander: gpio@20 { > + compatible = "onnn,pca9654"; > + reg = <0x20>; > + gpio-controller; > + #gpio-cells = <2>; You may want to describe that the interrupt output is tied to GP5_25? > + }; > + Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds