Re: [PATCH] mmc: remove another TMIO MMC variant usdhi6rol0.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Fri, Jun 21, 2019 at 03:16:11PM +0900, Masahiro Yamada wrote:
> (Added Lars Persson, Guennadi Liakhovetski)
> 
> On Fri, Jun 21, 2019 at 3:06 PM Masahiro Yamada
> <yamada.masahiro@xxxxxxxxxxxxx> wrote:
> 
> This needs Ack from Renesas.
> But, I do not know if TMIO folks are sure about this driver, though.
> (If they had been sure about it, they should not have duplicated the driver
> in the first place.)

... and from the original mail:

> Delete this driver now. Please re-implement it based on tmio_mmc_core.c
> if needed.

I was never happy with this driver existing, yet I never knew which HW
platform needed this, so I didn't touch it. But I'd like to see it go in
favor of merging with the TMIO code base.

> 
> Perhaps, some code snippets in this driver might be useful for cleaning
> tmio_mmc. It will stay in git history forever, and you can dig for it
> whenever you need it.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@xxxxxxxxxxxxx>

I double checked there is no user in the current tree. I also searched
the web and did not find any out-of-tree user or even a reference of it.

So, for now:

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

But this seriously needs an Ack from Shimoda-san or Morimoto-san. And
maybe Guennadi has remarks, too?

Thanks,

   Wolfram

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux