Hello Laurent,
Thank you for your feedback!
> From: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> Sent: 19 June 2019 15:36
> Subject: Re: [PATCH 3/3] arm64: dts: renesas: hihope-common: Add HDMI support
>
> Hi Fabrizio,
>
> On Wed, Jun 19, 2019 at 12:48:17PM +0000, Fabrizio Castro wrote:
> > On Sent: 19 June 2019 13:42 Laurent Pinchart wrote:
> > > On Tue, Jun 18, 2019 at 04:18:39PM +0100, Fabrizio Castro wrote:
> > >> Add HDMI support to the HiHope RZ/G2[MN] mother board common
> > >> dtsi.
> > >>
> > >> Signed-off-by: Fabrizio Castro <fabrizio.castro@xxxxxxxxxxxxxx>
> > >>
> > >> ---
> > >> Please note that this patch was tested with a 4K monitor and cma=96M
> > >>
> > >> arch/arm64/boot/dts/renesas/hihope-common.dtsi | 62 ++++++++++++++++++++++++++
> > >> 1 file changed, 62 insertions(+)
> > >>
> > >> diff --git a/arch/arm64/boot/dts/renesas/hihope-common.dtsi b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> index 625c3aa..e7568e1 100644
> > >> --- a/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> +++ b/arch/arm64/boot/dts/renesas/hihope-common.dtsi
> > >> @@ -17,6 +17,18 @@
> > >> stdout-path = "serial0:115200n8";
> > >> };
> > >>
> > >> + hdmi0-out {
> > >> + compatible = "hdmi-connector";
> > >> + label = "HDMI0 OUT";
> > >
> > > Is the label physically present on the device (printed on the board or
> > > the case) ?
> >
> > I am afraid it's not. Shall I send a v2? Or perhaps Simon could take it out while applying?
> >
> > > Apart from that, without access to the schematics I can't really tell if
> > > the DT is correct, but nothing strikes me as really wrong, so
> >
> > I didn't know you had no access to the schematics, on their way...
>
> Thank you. I confirm the DT looks good.
Thank you!
>
> On a side note, there's an ESD protection and level shifter chip between
> the HDMI output and the HDMI connector. On this board all its control
> pins are hardwired to fixed levels, so it's completely transparent, but
> in other cases it should be modelled in DT. I'm working on a driver for
> the TPD12S015 which should be quite similar, I will post it soon.
Good to know, I am looking forward to see it.
Thanks,
Fab
>
> > > Acked-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx>
> > >
> > >> + type = "a";
> > >> +
> > >> + port {
> > >> + hdmi0_con: endpoint {
> > >> + remote-endpoint = <&rcar_dw_hdmi0_out>;
> > >> + };
> > >> + };
> > >> + };
> > >> +
> > >> leds {
> > >> compatible = "gpio-leds";
> > >>
> > >> @@ -82,6 +94,30 @@
> > >> states = <3300000 1
> > >> 1800000 0>;
> > >> };
> > >> +
> > >> + x302_clk: x302-clock {
> > >> + compatible = "fixed-clock";
> > >> + #clock-cells = <0>;
> > >> + clock-frequency = <33000000>;
> > >> + };
> > >> +
> > >> + x304_clk: x304-clock {
> > >> + compatible = "fixed-clock";
> > >> + #clock-cells = <0>;
> > >> + clock-frequency = <25000000>;
> > >> + };
> > >> +};
> > >> +
> > >> +&du {
> > >> + clocks = <&cpg CPG_MOD 724>,
> > >> + <&cpg CPG_MOD 723>,
> > >> + <&cpg CPG_MOD 722>,
> > >> + <&versaclock5 1>,
> > >> + <&x302_clk>,
> > >> + <&versaclock5 2>;
> > >> + clock-names = "du.0", "du.1", "du.2",
> > >> + "dclkin.0", "dclkin.1", "dclkin.2";
> > >> + status = "okay";
> > >> };
> > >>
> > >> &ehci0 {
> > >> @@ -109,11 +145,37 @@
> > >> };
> > >> };
> > >>
> > >> +&hdmi0 {
> > >> + status = "okay";
> > >> +
> > >> + ports {
> > >> + port@1 {
> > >> + reg = <1>;
> > >> + rcar_dw_hdmi0_out: endpoint {
> > >> + remote-endpoint = <&hdmi0_con>;
> > >> + };
> > >> + };
> > >> + };
> > >> +};
> > >> +
> > >> &hsusb {
> > >> dr_mode = "otg";
> > >> status = "okay";
> > >> };
> > >>
> > >> +&i2c4 {
> > >> + clock-frequency = <400000>;
> > >> + status = "okay";
> > >> +
> > >> + versaclock5: clock-generator@6a {
> > >> + compatible = "idt,5p49v5923";
> > >> + reg = <0x6a>;
> > >> + #clock-cells = <1>;
> > >> + clocks = <&x304_clk>;
> > >> + clock-names = "xin";
> > >> + };
> > >> +};
> > >> +
> > >> &ohci0 {
> > >> status = "okay";
> > >> };
>
> --
> Regards,
>
> Laurent Pinchart
