Hi Magnus,
On Mon, Jun 17, 2019 at 11:16 AM Magnus Damm <magnus.damm@xxxxxxxxx> wrote:
> From: Magnus Damm <damm+renesas@xxxxxxxxxxxxx>
>
> Update the r8a7740 to use the CMT1 DT compat string documented in:
> [PATCH 2/8] dt-bindings: timer: renesas, cmt: Update CMT1 on sh73a0 and r8a7740
>
> The "renesas,cmt-48" portion is left as-is to avoid breakage until the CMT
> driver has been updated to make use of the new DT compat strings.
Hence wouldn't it be better to update the driver first, and the DTS in
the next release, so you can remove the "renesas,cmt-48" portion with
the single DTS update?
This is how it was done for R-Car Gen2:
v4.15 has commit 83c79a6d8d7f4821 ("clocksource/drivers/sh_cmt: Support
separate R-Car Gen2 CMT0/1"),
v4.16 has commit bf50e0ab4f5062bb ("ARM: dts: r8a7791: Update CMT compat
strings").
> --- 0001/arch/arm/boot/dts/r8a7740.dtsi
> +++ work/arch/arm/boot/dts/r8a7740.dtsi 2019-06-17 14:21:14.647792561 +0900
> @@ -83,7 +83,7 @@
> };
>
> cmt1: timer@e6138000 {
> - compatible = "renesas,cmt-48-r8a7740", "renesas,cmt-48";
> + compatible = "renesas,r8a7740-cmt1", "renesas,cmt-48";
> reg = <0xe6138000 0x170>;
> interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&mstp3_clks R8A7740_CLK_CMT1>;
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
