Hi Daniel, On Tue, Jun 18, 2019 at 03:21:55PM +0200, Daniel Vetter wrote: > On Tue, Jun 18, 2019 at 3:13 PM Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> wrote: > > > > The recommended way to specify GEM object functions is to provide a > > drm_gem_object_funcs structure instance and set the GEM object to point > > to it. The drm_cma_gem_create_object_default_funcs() function provided > > by the GEM CMA helper does so when creating the GEM object, simplifying > > the driver implementation. Switch to it, and remove the then unneeded > > GEM-related opertions from rcar_du_driver. > > > > Suggested-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 8 +------- > > 1 file changed, 1 insertion(+), 7 deletions(-) > > > > Daniel, is this what you had in mind ? > > Yup, I think that's it. Noralf commented that we might want to have > DRM_GEM_CMA_DRIVER_OPS macro for the remaining few drm_driver hooks, like > DRM_GEM_CMA_VMAP_DRIVER_OPS but without the forced vmap on import. But > that's ok to do in some follow-up cleanup too. On this: Note that the rcar-du driver requires a custom .dumb_create() operation, which is another reason why I can't use DRM_GEM_CMA_VMAP_DRIVER_OPS. > Reviewed-by: Daniel Vetter <daniel.vetter@xxxxxxxx> > > > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > index 3e5e835ea2b6..4cbb82009931 100644 > > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c > > @@ -445,16 +445,10 @@ DEFINE_DRM_GEM_CMA_FOPS(rcar_du_fops); > > static struct drm_driver rcar_du_driver = { > > .driver_features = DRIVER_GEM | DRIVER_MODESET | DRIVER_PRIME > > | DRIVER_ATOMIC, > > - .gem_free_object_unlocked = drm_gem_cma_free_object, > > - .gem_vm_ops = &drm_gem_cma_vm_ops, > > + .gem_create_object = drm_cma_gem_create_object_default_funcs, > > .prime_handle_to_fd = drm_gem_prime_handle_to_fd, > > .prime_fd_to_handle = drm_gem_prime_fd_to_handle, > > - .gem_prime_import = drm_gem_prime_import, > > - .gem_prime_export = drm_gem_prime_export, > > - .gem_prime_get_sg_table = drm_gem_cma_prime_get_sg_table, > > .gem_prime_import_sg_table = drm_gem_cma_prime_import_sg_table, > > - .gem_prime_vmap = drm_gem_cma_prime_vmap, > > - .gem_prime_vunmap = drm_gem_cma_prime_vunmap, > > .gem_prime_mmap = drm_gem_cma_prime_mmap, > > .dumb_create = rcar_du_dumb_create, > > .fops = &rcar_du_fops, -- Regards, Laurent Pinchart