Hi Simon, On Tue, Jun 18, 2019 at 12:45 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Mon, Jun 17, 2019 at 10:43:09AM +0200, Geert Uytterhoeven wrote: > > On Mon, Jun 17, 2019 at 10:37 AM Simon Horman > > <horms+renesas@xxxxxxxxxxxx> wrote: > > > From: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > > > > It is necessary to reset the LVDS Interface according to display on/off. > > > > This is not the LVDS interface. > > The LVDS interface has its own device node. > > Thanks, how about a changelog more like this? > > arm64: dts: renesas: r8a77990: Add cpg reset for DU > > Add CPG reset properties to DU node of E3 (r8a77990) SoC. Thanks, much better. > According to Laurent Pinchart, R-Car Gen3 reset is handled at the group > level so specifying one reset entry per group is sufficient. For this > reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an > earlier revision of this patch. Do we need this last sentence? Note that "dt-bindings: display: renesas: du: Document optional reset properties" hasn't been accepted in -next yet. > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > > Therefore, this patch adds CPG reset properties in DU device node > > > for the R8A77990 SoC. > > > > > > According to Laurent Pinchart, R-Car Gen3 reset is handled at the group > > > level so specifying one reset entry per group is sufficient. For this > > > reason <&cpg 724> is not listed as a reset for "du.1" as was the case in an > > > earlier revision of this patch. > > > > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > > Signed-off-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > --- > > > v2 [Simon Horman] > > > - only add one reset entry per group > > > --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi > > > @@ -1766,6 +1766,8 @@ > > > clocks = <&cpg CPG_MOD 724>, > > > <&cpg CPG_MOD 723>; > > > clock-names = "du.0", "du.1"; > > > + resets = <&cpg 724>; > > > + reset-names = "du.0"; > > > vsps = <&vspd0 0 &vspd1 0>; > > > status = "disabled"; Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds