RE: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C DRP port controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Greg,

> Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB Type-C
> DRP port controller
> 
> > > Subject: Re: [PATCH v7 3/7] usb: typec: driver for TI HD3SS3220 USB
> > > Type-C DRP port controller
> > >
> > > On Fri, May 31, 2019 at 10:59:56AM +0100, Biju Das wrote:
> > > > Driver for TI HD3SS3220 USB Type-C DRP port controller.
> > > >
> > > > The driver currently registers the port and supports data role swapping.
> > > >
> > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
> > > > Acked-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx>
> > > > ---
> > >
> > > I tried to apply this, but get the following build error:
> > >
> > > drivers/usb/typec/hd3ss3220.c: In function hd3ss3220_probe:
> > > drivers/usb/typec/hd3ss3220.c:179:23: error: implicit declaration of
> > > function fwnode_usb_role_switch_get; did you mean
> > > usb_role_switch_get? [- Werror=implicit-function-declaration]
> > >   hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
> > >                        ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > >                        usb_role_switch_get
> > > drivers/usb/typec/hd3ss3220.c:179:21: warning: assignment to struct
> > > usb_role_switch * from int makes pointer from integer without a cast
> > > [-Wint- conversion]
> > >   hd3ss3220->role_sw = fwnode_usb_role_switch_get(connector);
> > >                      ^
> > >
> > > You might want to fix that so the series can be applied :(
> >
> > This patch depend upon the  below commit[1] which introduced the new
> API "fwnode_usb_role_switch_get()"
> >
> > [1] https://patchwork.kernel.org/patch/10986227/ ("usb: roles: Add
> > fwnode_usb_role_switch_get() function")
> 
> Ok, then I guess I will have to wait to merge this until that is accepted.
> 
> Please resend when that happens.

OK.  I will resend this patch after  patch [1]  get accepted.

Regards,
Biju




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux