Re: [PATCH 1/4] media: cxd2820r: don't check retval after our own assignemt

[Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>]

Hi Wolfram,


In the title/subject:

media: cxd2820r: don't check retval after our own assignemt

s/assignemt/assignment/


On 13/06/2019 16:54, Wolfram Sang wrote:
> No need to check a retval after we assigned a constant to it.

Hrm... Good spots!

> Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> ---
>  drivers/media/dvb-frontends/cxd2820r_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/media/dvb-frontends/cxd2820r_core.c b/drivers/media/dvb-frontends/cxd2820r_core.c
> index 1f006f8e8cc2..99a186ddddb2 100644
> --- a/drivers/media/dvb-frontends/cxd2820r_core.c
> +++ b/drivers/media/dvb-frontends/cxd2820r_core.c
> @@ -636,8 +636,7 @@ static int cxd2820r_probe(struct i2c_client *client,
>  	if (!priv->client[1]) {
>  		ret = -ENODEV;
>  		dev_err(&client->dev, "I2C registration failed\n");
> -		if (ret)

Can't argue with that.

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@xxxxxxxxxxxxxxxx>

> -			goto err_regmap_0_regmap_exit;
> +		goto err_regmap_0_regmap_exit;
>  	}
>  
>  	priv->regmap[1] = regmap_init_i2c(priv->client[1], &regmap_config1);
>