Re: [PATCH v3 1/4] pwm: Add power management descriptions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, May 31, 2019 at 06:54:58PM +0900, Yoshihiro Shimoda wrote:
> This patch adds power management descriptions that consumers should
> implement it.
> 
> Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx>

> ---
>  Documentation/pwm.txt | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/pwm.txt b/Documentation/pwm.txt
> index 8fbf0aa..ab62f1b 100644
> --- a/Documentation/pwm.txt
> +++ b/Documentation/pwm.txt
> @@ -65,6 +65,10 @@ period). struct pwm_args contains 2 fields (period and polarity) and should
>  be used to set the initial PWM config (usually done in the probe function
>  of the PWM user). PWM arguments are retrieved with pwm_get_args().
>  
> +All consumers should really be reconfiguring the PWM upon resume as
> +appropriate. This is the only way to ensure that everything is resumed in
> +the proper order.
> +
>  Using PWMs with the sysfs interface
>  -----------------------------------
>  
> @@ -141,6 +145,9 @@ The implementation of ->get_state() (a method used to retrieve initial PWM
>  state) is also encouraged for the same reason: letting the PWM user know
>  about the current PWM state would allow him to avoid glitches.
>  
> +Drivers should not implement any power management. In other words,
> +consumers should implement it as described in the "Using PWMs" section.
> +
>  Locking
>  -------
>  
> -- 
> 2.7.4
> 




[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux