RE: [PATCH] arm64: dts: renesas: hihope-common: Add uSD and eMMC

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Wolfram,

Thank you for your feedback!

> From: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Sent: 12 June 2019 11:15
> Subject: Re: [PATCH] arm64: dts: renesas: hihope-common: Add uSD and eMMC
> 
> 
> > File arch/arm64/boot/dts/renesas/hihope-common.dtsi contains common
> > definitions for the mother boards for both flavours (including the
> > eMMC). My understanding is that R-Car M3-N does support HS400, hence
> > the need for the property here.
> 
> I won't be super strict here, yet I think it is more elegant to add the
> HS400 properties to the board DTS files, not the dtsi. I mean we could
> add them to the SoC dtsi otherwise.

We will give both approaches a shot in due time, once the relevant HW
will be available, but I do wonder why we need to make a distinction in the DT
when we have a quirk in the driver (the real problem is that HS400 doesn't work
only on some revisions of the RZ/G2M chip, do we need to create different .dtsi for
different revisions of the same SoC? Or perhaps different versions of the same board
dts?)? We could simply put a comment in the DT once we add the compatibility of the
eMMC with HS400, something like:
"HS400 won't work on RZ/G2M rev=1.2"
and let the driver handle the difference between revisions of the SoC, this would keep
things as compact as they possibly can be, as well as simplify design and maintenance.

I hope this helps.

Thanks,
Fab







[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux