Hi Geert, On Sun, Jun 09, 2019 at 10:06:19AM +0200, Geert Uytterhoeven wrote: > On Sat, Jun 8, 2019 at 2:55 PM Laurent Pinchart wrote: > > This helps identifying the IP core version, for debugging purpose only > > for now. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > Thanks for your patch! > > > --- a/drivers/media/platform/rcar-fcp.c > > +++ b/drivers/media/platform/rcar-fcp.c > > > @@ -138,6 +168,19 @@ static int rcar_fcp_probe(struct platform_device *pdev) > > > > pm_runtime_enable(&pdev->dev); > > > > + mem = platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + fcp->iomem = devm_ioremap_resource(&pdev->dev, mem); > > devm_platform_ioremap_resource()? Nice, I've thought about adding such a function for some time, I didn't know it had been merged. > > + if (IS_ERR(fcp->iomem)) > > + return PTR_ERR(fcp->iomem); > > + > > + pm_runtime_get_sync(&pdev->dev); > > + version = rcar_fcp_read(fcp, FCP_VCR); > > Please note that rcar_fcp_read() does not exist in upstream nor next, > and linux-renesas-soc hasn't seen the patch that added it. That's why it was added in this patch :-) -- Regards, Laurent Pinchart
