Hi Simon-san, > From: Simon Horman, Sent: Tuesday, June 4, 2019 6:36 PM > > Hi Shimoda-san, > > On Tue, Jun 04, 2019 at 01:09:34PM +0900, Yoshihiro Shimoda wrote: > > SUDMAC featurer was supported in v3.10, but was never used by > > any platform. So, this patch removes it. > > > > Signed-off-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@xxxxxxxxxxx> > > --- > > drivers/usb/renesas_usbhs/fifo.c | 5 +---- > > include/linux/usb/renesas_usbhs.h | 1 - > > 2 files changed, 1 insertion(+), 5 deletions(-) > > > > diff --git a/drivers/usb/renesas_usbhs/fifo.c b/drivers/usb/renesas_usbhs/fifo.c > > index 452b456..53f8e2f 100644 > > --- a/drivers/usb/renesas_usbhs/fifo.c > > +++ b/drivers/usb/renesas_usbhs/fifo.c > > @@ -325,10 +325,7 @@ static int usbhsf_fifo_select(struct usbhs_pipe *pipe, > > } > > > > /* "base" will be used below */ > > - if (usbhs_get_dparam(priv, has_sudmac) && !usbhsf_is_cfifo(priv, fifo)) > > I believe usbhsf_is_cfifo() will now be unused and should be removed. Good catch! I'll remove the macro on v2. > With that change feel free to add: > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> Thank you for your review! Best regards, Yoshihiro Shimoda
