Re: [PATCH] clk: renesas: cpg-mssr: Use genpd of_node instead of local copy

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Geert,

Thanks for your work.

On 2019-05-27 14:33:23 +0200, Geert Uytterhoeven wrote:
> Since commit 6a0ae73d95956f7e ("PM / Domain: Add support to parse
> domain's OPP table"), of_genpd_add_provider_simple() fills in
> the dev.of_node field in the generic_pm_domain structure.
> 
> Hence cpg_mssr_is_pm_clk() can use that instead of its own copy in the
> driver-private cpg_mssr_clk_domain structure.
> 
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
> To be queued in clk-renesas-for-v5.3.
> 
>  drivers/clk/renesas/renesas-cpg-mssr.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
> index 0201809bbd377df4..d1054204f3a75022 100644
> --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> @@ -447,7 +447,6 @@ static void __init cpg_mssr_register_mod_clk(const struct mssr_mod_clk *mod,
>  
>  struct cpg_mssr_clk_domain {
>  	struct generic_pm_domain genpd;
> -	struct device_node *np;
>  	unsigned int num_core_pm_clks;
>  	unsigned int core_pm_clks[0];
>  };
> @@ -459,7 +458,7 @@ static bool cpg_mssr_is_pm_clk(const struct of_phandle_args *clkspec,
>  {
>  	unsigned int i;
>  
> -	if (clkspec->np != pd->np || clkspec->args_count != 2)
> +	if (clkspec->np != pd->genpd.dev.of_node || clkspec->args_count != 2)
>  		return false;
>  
>  	switch (clkspec->args[0]) {
> @@ -549,7 +548,6 @@ static int __init cpg_mssr_add_clk_domain(struct device *dev,
>  	if (!pd)
>  		return -ENOMEM;
>  
> -	pd->np = np;
>  	pd->num_core_pm_clks = num_core_pm_clks;
>  	memcpy(pd->core_pm_clks, core_pm_clks, pm_size);
>  
> -- 
> 2.17.1
> 

-- 
Regards,
Niklas Söderlund



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux