On Wed, May 29, 2019 at 02:21:46PM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, May 29, 2019 at 12:35 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > > On Wed, May 29, 2019 at 12:29:39PM +0200, Simon Horman wrote: > > > On Mon, May 27, 2019 at 02:35:14PM +0200, Geert Uytterhoeven wrote: > > > > pm_clk_create() and pm_clk_add_clk() can fail only when running out of > > > > memory. Hence there is no need to print error messages on failure, as > > > > the memory allocation core already takes care of that. > > > > > > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > > > > > Reviewed-by: Simon Horman <horms+renesas@xxxxxxxxxxxx> > > > > On a closer look, I see that pm_clk_add_clk() can return > > errors for other reasons. Can they never occur in this use-case? > > These are the cases where con_id is non-NULL, right? > pm_clk_add_clk() calls __pm_clk_add() with con_id == NULL. > > Or do you mean the case where clk is an error pointer? That cannot > happen neither. I was referring to the latter. But if it can't happen then I'm happy with this patch.
