Hi Jacopo, On Tue, May 28, 2019 at 11:28:47AM +0200, Jacopo Mondi wrote: > On Sun, May 12, 2019 at 12:06:56AM +0300, Laurent Pinchart wrote: > > Add a new optional renesas,companion property to point to the companion > > LVDS encoder. This is used to support dual-link operation where the main > > LVDS encoder splits even-numbered and odd-numbered pixels between the > > two LVDS encoders. > > > > The new property doesn't control the mode of operation, it only > > describes the relationship between the master and companion LVDS > > encoders. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@xxxxxxxxxxxxxxxx> > > --- > > Changes since v1: > > > > - Fixed typo > > --- > > .../devicetree/bindings/display/bridge/renesas,lvds.txt | 6 ++++++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > index 900a884ad9f5..f2cc01d54cbd 100644 > > --- a/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > +++ b/Documentation/devicetree/bindings/display/bridge/renesas,lvds.txt > > @@ -45,6 +45,12 @@ OF graph bindings specified in Documentation/devicetree/bindings/graph.txt. > > > > Each port shall have a single endpoint. > > > > +Optional properties: > > + > > +- renesas,companion : phandle to the companion LVDS encoder. This property is > > + valid for the first LVDS encoder on D3 and E3 SoCs only, and points to the > > + second encoder to be used as a companion in dual-link mode. > > + > > If I got this right, the property does not enable dual-link > operations by itself, but it needs the next bridge to be operating in > dual link mode (ie. has both LVDS0 and LVDS1 output connected to its > input ports). Correct. > Is it worth describing it here (or at least clarify the the property > alone does not enable dual link operations). How about the following ? - renesas,companion : phandle to the companion LVDS encoder. This property is mandatory for the first LVDS encoder on D3 and E3 SoCs, and shall point to the second encoder to be used as a companion in dual-link mode. It shall not be set for any other LVDS encoder. > Apart from that > Reviewed-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> -- Regards, Laurent Pinchart
