On 28.05.19 11:27, Geert Uytterhoeven wrote:
Hi Oleksandr,
Hi Geert, all
Thanks for the update!
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Thank you for review!
Just FYI:
Required support for Gen2 Stout board has been already added to Xen [1].
What needs to be done next is to add support for handling device-tree
nodes with "interrupts-extended" property in Xen [2].
This is related to Gen3 as well.
[1]
https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxxxxxxxxx/msg44386.html
[2]
https://www.mail-archive.com/xen-devel@xxxxxxxxxxxxxxxxxxxx/msg45951.html
Two cosmetic comments below. I'll leave it to Simon to ignore them for
applying ;-)
@@ -62,6 +63,21 @@ void __init rcar_gen2_timer_init(void)
{
void __iomem *base;
u32 freq;
+ bool need_update = true;
Some people like reverse Xmas tree declaration order...
+
+ /*
+ * If PSCI is available then most likely we are running on PSCI-enabled
+ * U-Boot which, we assume, has already taken care of resetting CNTVOFF
+ * and updating counter module before switching to non-secure mode
+ * and we don't need to.
+ */
+#if defined(CONFIG_ARM_PSCI_FW)
#ifdef CONFIG_ARM_PSCI_FW ?
Gr{oetje,eeting}s,
Geert
--
Regards,
Oleksandr Tyshchenko
