Re: [PATCH] ravb: implement MTU change while device is up

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > > > >    How about the code below instead?
> > > > > > 
> > > > > > 	if (netif_running(ndev))
> > > > > > 		ravb_close(ndev);
> > > > > > 
> > > > > >  	ndev->mtu = new_mtu;
> > > > > > 	netdev_update_features(ndev);
> > > > > 
> > > > > Is there a need to call netdev_update_features() even if the if is not 
> > > > > running?
> > > > 
> > > > In my testing, it didn't seem so.
> > > 
> > > That may be because your testing doesn't cover cases where it would make
> > > any difference.
> > 
> > Cases other than changing the MTU while the device is up?
> 
> I was thinking of cases where listeners are registered for the
> notifier that netdev_update_features() triggers.

Where are we here? Is this a blocker?

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux