On 2019-05-16 23:13, Wolfram Sang wrote: > From: Heiner Kallweit <hkallweit1@xxxxxxxxx> > > Currently i2c_new_device and i2c_new_dummy return just NULL in error > case although they have more error details internally. Therefore move > the functionality into new functions returning detailed errors and > add wrappers for compatibility with the current API. > > This allows to use these functions with detailed error codes within > the i2c core or for API extensions. > > Signed-off-by: Heiner Kallweit <hkallweit1@xxxxxxxxx> > [wsa: rename new functions and fix minor kdoc issues] > Signed-off-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> The only nit I can find is that you could perhaps sweep the patches with sed 's/i2c /I2C /'. But that is indeed a nit, so if you're in a hurry... Reviewed-by: Peter Rosin <peda@xxxxxxxxxx> Cheers, Peter