Hi Jacopo, Thank you for the patch. On Wed, May 08, 2019 at 07:34:21PM +0200, Jacopo Mondi wrote: > Document the newly added 'cmms' property which accepts a list of phandle > and channel index pairs that point to the CMM units available for each > Display Unit output video channel. > > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx> > --- > Documentation/devicetree/bindings/display/renesas,du.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/display/renesas,du.txt b/Documentation/devicetree/bindings/display/renesas,du.txt > index aedb22b4d161..2ccf78bf9a18 100644 > --- a/Documentation/devicetree/bindings/display/renesas,du.txt > +++ b/Documentation/devicetree/bindings/display/renesas,du.txt > @@ -44,6 +44,10 @@ Required Properties: > instance that serves the DU channel, and the channel index identifies the > LIF instance in that VSP. > > + - cmms: A list of phandle and channel index tuples to the CMM modules > + connected to DU channels. The phandle identifies the CMM instance that > + serves the DU channel identified by the index. Do we need the index ? It should also be noted that the property is optional for SoCs that don't have any CMM. > + > Required nodes: > > The connections to the DU output video ports are modeled using the OF graph Could you update the example ? -- Regards, Laurent Pinchart