Re: [PATCH v2 08/15] usb: renesas_usbhs: move flags macros

Sergei Shtylyov <sergei.shtylyov@xxxxxxxxxxxxxxxxxx> · Fri, 10 May 2019 11:41:38 +0300

On 09.05.2019 23:11, Chris Brandt wrote:

Move flags macros to header file so they can be used by other files.

Signed-off-by: Chris Brandt <chris.brandt@xxxxxxxxxxx>
---
  drivers/usb/renesas_usbhs/common.c |  7 -------
  drivers/usb/renesas_usbhs/common.h | 10 ++++++++++
  2 files changed, 10 insertions(+), 7 deletions(-)

diff --git a/drivers/usb/renesas_usbhs/common.c b/drivers/usb/renesas_usbhs/common.c
index 249fbee97f3f..efb26ffd9809 100644
--- a/drivers/usb/renesas_usbhs/common.c
+++ b/drivers/usb/renesas_usbhs/common.c
@@ -44,13 +44,6 @@
   */
  
  
-#define USBHSF_RUNTIME_PWCTRL	(1 << 0)
-
-/* status */
-#define usbhsc_flags_init(p)   do {(p)->flags = 0; } while (0)
-#define usbhsc_flags_set(p, b) ((p)->flags |=  (b))
-#define usbhsc_flags_clr(p, b) ((p)->flags &= ~(b))
-#define usbhsc_flags_has(p, b) ((p)->flags &   (b))
  

   Why leave 3 empty lines?

  /*
   * platform call back
[...]

MBR, Sergei






