Hi Geert-san, > From: Geert Uytterhoeven, Sent: Friday, May 10, 2019 4:07 PM > > Hi Chris, > > On Thu, May 9, 2019 at 10:14 PM Chris Brandt <chris.brandt@xxxxxxxxxxx> wrote: <snip> > BTW, this driver uses a mix of feature checking using USBHS_TYPE_* > enums, and a parameter block/callback struct > (renesas_usbhs_platform_callback). Perhaps the feature flags can just > be moved to the struct, and the various structs referenced from > of_device_id.data? Thank you for your comment! I think so. So, I'll make such a patch later. Best regards, Yoshihiro Shimoda > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds