Hi Geert,
Thanks for the feedback.
> Subject: Re: [PATCH 1/6] arm64: dts: r8a774a1: Add VSP instances
>
> Hi Biju,
>
> On Tue, Apr 16, 2019 at 5:38 PM Biju Das <biju.das@xxxxxxxxxxxxxx> wrote:
> > The r8a774a1 soc has 5 VSP instances similar to r8a7796.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
>
> > --- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
> > @@ -1877,6 +1877,61 @@
> > iommus = <&ipmmu_vc0 19>;
> > };
> >
> > + vspb: vsp@fe960000 {
> > + compatible = "renesas,vsp2";
> > + reg = <0 0xfe960000 0 0x8000>;
> > + interrupts = <GIC_SPI 266 IRQ_TYPE_LEVEL_HIGH>;
> > + clocks = <&cpg CPG_MOD 626>;
> > + power-domains = <&sysc R8A774A1_PD_A3VC>;
>
> I have my doubts about vspb (and fcpvb0) being part of the A3VC power
> domain (also on R-Car M3-W).
As per R-Car Gen3 Rev.1.50 Nov 2018 Hardware user's manual it is A3VC,
The details are mentioned in Table 9.4 Power domains for A3VP.
A3VP :- This domain is available only for R-CarH3, R-Car H3-N and R-Car M3-N.Modules included in this domain was
Moved to A3VC domain for R-Car M3-W.
Regards,
Biju
>
> > + resets = <&cpg 626>;
> > +
> > + renesas,fcp = <&fcpvb0>;
> > + };
>
> Apart from that:
> Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
