Hi Simon, Thanks for the feedback. I missed to add the dependency for this patch. This patch has dependency on https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20190424&id=5d8042e95fd471d0e342cf14f127194f1a867a01 regards, Biju > -----Original Message----- > From: Simon Horman <horms@xxxxxxxxxxxx> > Sent: 24 April 2019 10:33 > To: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> > Cc: Biju Das <biju.das@xxxxxxxxxxxxxx>; Magnus Damm > <magnus.damm@xxxxxxxxx>; Russell King <linux@xxxxxxxxxxxxxxx>; Linux- > Renesas <linux-renesas-soc@xxxxxxxxxxxxxxx>; Linux ARM <linux-arm- > kernel@xxxxxxxxxxxxxxxxxxx>; Geert Uytterhoeven > <geert+renesas@xxxxxxxxx>; Chris Paterson > <Chris.Paterson2@xxxxxxxxxxx>; Fabrizio Castro > <fabrizio.castro@xxxxxxxxxxxxxx> > Subject: Re: [PATCH] ARM: shmobile: Remove GENERIC_PHY from > shmobile_defconfig > > On Wed, Apr 24, 2019 at 09:12:04AM +0200, Geert Uytterhoeven wrote: > > On Tue, Apr 23, 2019 at 3:20 PM Biju Das <biju.das@xxxxxxxxxxxxxx> > wrote: > > > Remove the GENERIC_PHY config option from shmobile_defconfig, as it > > > is selected by PHY_RCAR_GEN3_USB2. > > > > > > PHY_RCAR_GEN3_USB2 is enabled by the commit > > > 0cd4f4f10245d1d9616e00245 > > > ("ARM: shmobile: Enable PHY_RCAR_GEN3_USB2 in > shmobile_defconfig"). > > > > > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > > > > Acked-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > > This does not seem to work as expected when applied on top of renesas- > devel-20190423-v5.1-rc5. > > Without this patch I see both CONFIG_GENERIC_PHY and > CONFIG_PHY_RCAR_GEN selected. With this patch I see neither selected, I > expected both. > > --- .config.old 2019-04-24 11:31:12.480520934 +0200 > +++ .config 2019-04-24 11:31:34.732852122 +0200 > @@ -4272,7 +4272,7 @@ > # > # PHY Subsystem > # > -CONFIG_GENERIC_PHY=y > +# CONFIG_GENERIC_PHY is not set > # CONFIG_BCM_KONA_USB2_PHY is not set > # CONFIG_PHY_CADENCE_DP is not set > # CONFIG_PHY_CADENCE_DPHY is not set > @@ -4282,7 +4282,6 @@ > # CONFIG_PHY_PXA_28NM_USB2 is not set > # CONFIG_PHY_CPCAP_USB is not set > # CONFIG_PHY_MAPPHONE_MDM6600 is not set - > CONFIG_PHY_RCAR_GEN2=y # CONFIG_PHY_RCAR_GEN3_PCIE is not set # > CONFIG_PHY_RCAR_GEN3_USB3 is not set # CONFIG_POWERCAP is not set
