Hi Simon, On Mon, Apr 8, 2019 at 2:29 PM Simon Horman <horms@xxxxxxxxxxxx> wrote: > On Thu, Jan 10, 2019 at 05:33:57PM +0100, Niklas Söderlund wrote: > > On 2018-12-21 05:49:39 +0900, Yoshihiro Kaneko wrote: > > > From: Dien Pham <dien.pham.ry@xxxxxxxxxxx> > > > > > > [dien.pham.ry: arm64: dts: r8a7795: Add support IPA for CA53 core] > > > > > > Setup a thermal zone driven by SoC temperature sensor. > > > Create passive trip points and bind them to CPUFreq cooling > > > device that supports power extension. > > > > > > In R-Car Gen3, IPA is supportted for only one channel > > > (on H3/M3/M3N board, it is channel THS3). Reason: > > > Currently, IPA controls base on only CPU temperature. > > > And only one thermal channel is assembled closest > > > CPU cores is selected as target of IPA. > > > If other channels are used, IPA controlling is not properly. > > > > > > Signed-off-by: Keita Kobayashi <keita.kobayashi.ym@xxxxxxxxxxx> > > > [gaku.inami.xw: fix the trip temperature for cooling-device] > > > [gaku.inami.xw: fix the power coefficient] > > > Signed-off-by: Gaku Inami <gaku.inami.xw@xxxxxxxxxxxxxx> > > > Signed-off-by: Hien Dang <hien.dang.eb@xxxxxxxxxxxxxxx> > > > Signed-off-by: An Huynh <an.huynh.uj@xxxxxxxxxxxxxxx> > > > [takeshi.kihara.df: fix W=1 dtc unit_address_vs_reg warnings] > > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@xxxxxxxxxxx> > > > Signed-off-by: Yoshihiro Kaneko <ykaneko0929@xxxxxxxxx> > > > --- > > > > > > This patch is based on the devel branch of Simon Horman's renesas tree. > > > > > > arch/arm64/boot/dts/renesas/r8a7795.dtsi | 64 ++++++++++++++------------------ > > > 1 file changed, 27 insertions(+), 37 deletions(-) > > > > > > diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > > index af9605d..dd52b50 100644 > > > --- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > > +++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi > > > @@ -155,6 +155,9 @@ > > > power-domains = <&sysc R8A7795_PD_CA57_CPU0>; > > > next-level-cache = <&L2_CA57>; > > > enable-method = "psci"; > > > + dynamic-power-coefficient = <854>; > > > + cooling-min-level = <0>; > > > + cooling-max-level = <2>; > > > > I can't find any documentation or code which makes use of the > > cooling-min-level and cooling-max-level properties on v5.0-rc1. What is > > the intended usage for these properties? > > It looks like these properties were removed in v4.17-rc1 by > bbcf071969b2 ("cpufreq: cpu0: rename driver and internals to 'cpufreq_dt'") > and should be dropped from this and similar patches. See commit e04907dbc25930b8 ("dt-bindings: thermal: Remove "cooling-{min|max}-level" properties"). Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds