When trying to add DT support to the DA9063 WDT, I didn't want to add yet another error message when watchdog_init_timeout fails. The core could do this with more detail, and also much more consistent. So, I refactored this routine and removed error strings from its callers. Note that DA9063 support is not added here but was sent seperately[1]. This series has been tested using the renesas_wdt driver on a Renesas Salvator-XS board (R-Car M3N) and build bot is happy, too. Changes since V1: * return -EINVAL if DT supplied a value of '0' [patch 1] * update kdoc to mention that DT cannot be '0' but module_param can be [patch 1] * add Guenter's Rev-by to all patches except patch 1 * add driver maintainers to CC this time Looking forward to comments. Thanks, Wolfram [1] https://patchwork.kernel.org/patch/10899801/ Wolfram Sang (16): watchdog: refactor watchdog_init_timeout watchdog: add error messages when initializing timeout fails watchdog: cadence_wdt: drop warning after calling watchdog_init_timeout watchdog: cadence_wdt: still probe if user supplied timeout is invalid watchdog: ebc-c384_wdt: drop warning after calling watchdog_init_timeout watchdog: hpwdt: drop warning after calling watchdog_init_timeout watchdog: i6300esb: drop warning after calling watchdog_init_timeout watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout watchdog: ni903x_wdt: drop warning after calling watchdog_init_timeout watchdog: nic7018_wdt: drop warning after calling watchdog_init_timeout watchdog: renesas_wdt: drop warning after calling watchdog_init_timeout watchdog: sp5100_tco: drop warning after calling watchdog_init_timeout watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout watchdog: xen_wdt: drop warning after calling watchdog_init_timeout watchdog: ziirave_wdt: drop warning after calling watchdog_init_timeout drivers/watchdog/cadence_wdt.c | 7 +------ drivers/watchdog/ebc-c384_wdt.c | 5 +---- drivers/watchdog/hpwdt.c | 3 +-- drivers/watchdog/i6300esb.c | 5 +---- drivers/watchdog/imx_sc_wdt.c | 5 +---- drivers/watchdog/ni903x_wdt.c | 4 +--- drivers/watchdog/nic7018_wdt.c | 5 +---- drivers/watchdog/renesas_wdt.c | 4 +--- drivers/watchdog/sp5100_tco.c | 4 +--- drivers/watchdog/st_lpc_wdt.c | 4 +--- drivers/watchdog/stm32_iwdg.c | 6 +----- drivers/watchdog/watchdog_core.c | 39 +++++++++++++++++++++++++-------------- drivers/watchdog/xen_wdt.c | 4 +--- drivers/watchdog/ziirave_wdt.c | 6 +----- 14 files changed, 38 insertions(+), 63 deletions(-) -- 2.11.0
