> On April 13, 2019 at 1:43 AM Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx> wrote:
>
>
> Runtime PM is already enable unconditionally when the driver is probed
> and disabled when it's removed. There is no point in doing it again for
> Gen2 when opening and closing the video device.
>
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>
> ---
> drivers/media/platform/rcar-vin/rcar-v4l2.c | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> index b821ea01786eb1ff..0841f1a0bfd7ba3a 100644
> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> @@ -797,8 +797,6 @@ static int rvin_initialize_device(struct file *file)
> if (ret < 0)
> return ret;
>
> - pm_runtime_enable(&vin->vdev.dev);
> -
> /*
> * Try to configure with default parameters. Notice: this is the
> * very first open, so, we cannot race against other calls,
> @@ -813,7 +811,6 @@ static int rvin_initialize_device(struct file *file)
>
> return 0;
> esfmt:
> - pm_runtime_disable(&vin->vdev.dev);
> rvin_power_off(vin);
>
> return ret;
> @@ -863,10 +860,8 @@ static int rvin_release(struct file *file)
> * If this was the last open file.
> * Then de-initialize hw module.
> */
> - if (fh_singular) {
> - pm_runtime_disable(&vin->vdev.dev);
> + if (fh_singular)
> rvin_power_off(vin);
> - }
>
> mutex_unlock(&vin->lock);
>
> --
> 2.21.0
>
Reviewed-by: Ulrich Hecht <uli+renesas@xxxxxxxx>
CU
Uli
