On Fri, Apr 12, 2019 at 02:00:53PM +0200, Niklas Söderlund wrote:
> Hi Jacopo,
>
> Thanks for your patch.
>
> On 2019-04-12 13:38:32 +0200, Jacopo Mondi wrote:
> > Add the "renesas,id" property to VIN nodes in the R-Car V3H R8A77980
> > device tree.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
>
> Reviewed-by: Niklas Söderlund <niklas.soderlund@xxxxxxxxxxxx>
...
On Sat, Apr 13, 2019 at 09:25:08PM +0300, Sergei Shtylyov wrote:
> On 04/12/2019 02:38 PM, Jacopo Mondi wrote:
>
> > Add the "renesas,id" property to VIN nodes in the R-Car V3H R8A77980
> > device tree.
> >
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@xxxxxxxxxx>
> > ---
> >
> > I do not have a V3H board to test on, but I suspect VIN failed to probe
> > on V3H before these 2 patches.
>
> Yes, probably. The upstream patch wasn't ever runtime tested, so this
> went unnoticed. The BSPs use the old soc_camera driver.
>
> > If that's the case, these patches would merit
> > Fixes: 3182aa4e0bf4 ("arm64: dts: renesas: r8a77980: add CSI2/VIN support")
>
> I'm OK with that.
>
> > Sergei, do you still have a V3H board around? Could I have your Tested-by
> > tag if things are fine now?
>
> I have V3H Stater Kit on my desk but I don't think it has VINs wired to
> anything...
...
Thanks everyone,
I have applied this for inclusion in v5.2 with the fixes tag.
