On 4/14/19 3:26 AM, Wolfram Sang wrote:
When trying to add DT support to the DA9063 WDT, I didn't want to add yet
another error message when watchdog_init_timeout fails. The core could do this
with more detail, and also much more consistent. So, I refactored this routine
and removed error strings from its callers. Note that DA9063 support is not
added here because I still need to think about another issue. But this series
has been tested using the renesas_wdt driver on a Renesas Salvator-XS board
(R-Car M3N) and build bot is happy, too.
Looking forward to comments.
I like the idea. We should probably do the same for [devm_]watchdog_register_device().
For the series, except patch 1:
Reviewed-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Thanks,
Guenter
Thanks,
Wolfram
Wolfram Sang (16):
watchdog: refactor watchdog_init_timeout
watchdog: add error messages when initializing timeout fails
watchdog: cadence_wdt: drop warning after calling
watchdog_init_timeout
watchdog: cadence_wdt: still probe if user supplied timeout is invalid
watchdog: ebc-c384_wdt: drop warning after calling
watchdog_init_timeout
watchdog: hpwdt: drop warning after calling watchdog_init_timeout
watchdog: i6300esb: drop warning after calling watchdog_init_timeout
watchdog: imx_sc_wdt: drop warning after calling watchdog_init_timeout
watchdog: ni903x_wdt: drop warning after calling watchdog_init_timeout
watchdog: nic7018_wdt: drop warning after calling
watchdog_init_timeout
watchdog: renesas_wdt: drop warning after calling
watchdog_init_timeout
watchdog: sp5100_tco: drop warning after calling watchdog_init_timeout
watchdog: st_lpc_wdt: drop warning after calling watchdog_init_timeout
watchdog: stm32_iwdg: drop warning after calling watchdog_init_timeout
watchdog: xen_wdt: drop warning after calling watchdog_init_timeout
watchdog: ziirave_wdt: drop warning after calling
watchdog_init_timeout
drivers/watchdog/cadence_wdt.c | 7 +------
drivers/watchdog/ebc-c384_wdt.c | 5 +----
drivers/watchdog/hpwdt.c | 3 +--
drivers/watchdog/i6300esb.c | 5 +----
drivers/watchdog/imx_sc_wdt.c | 5 +----
drivers/watchdog/ni903x_wdt.c | 4 +---
drivers/watchdog/nic7018_wdt.c | 5 +----
drivers/watchdog/renesas_wdt.c | 4 +---
drivers/watchdog/sp5100_tco.c | 4 +---
drivers/watchdog/st_lpc_wdt.c | 4 +---
drivers/watchdog/stm32_iwdg.c | 6 +-----
drivers/watchdog/watchdog_core.c | 39 ++++++++++++++++++++++++---------------
drivers/watchdog/xen_wdt.c | 4 +---
drivers/watchdog/ziirave_wdt.c | 6 +-----
14 files changed, 37 insertions(+), 64 deletions(-)
