Hi Kieran,
Thanks for the feedback.
> Subject: Re: [PATCH 3/4] drm: rcar-du: Add R8A774A1 support
>
> Hi Biju,
>
> On 11/04/2019 15:34, Biju Das wrote:
> > Add support for the R8A774A1 DU (which is very similar to the R8A7796
> > DU); it has one RGB output, one LVDS output and one HDMI output.
> >
> > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx>
>
> I see Figure 35.1b across the two datasheets does show some differences
> between these two parts, but the layout defined by the
> rcar_du_r8a7796_info structure is compatible based on the current state of
> the driver...
>
> However, if support for the TCON/CMM is added to the DU driver - then I
> think this will need to be separated.
OK. I will send V2 with separate data structure " rcar_du_r8a774a1_info"
for RZ/G2M.
Regards,
Biju
> I have seen patches this month which are trying to upstream a CMM
> implementation.
>
> With that in mind - perhaps it would be worth creating a new structure for
> this part?
>
> Otherwise the CMM would end up being enabled when it doesn't exist and
> could cause problems.
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_drv.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > index 75ab17a..f7a5314 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> > @@ -386,6 +386,7 @@ static const struct of_device_id rcar_du_of_table[]
> = {
> > { .compatible = "renesas,du-r8a7744", .data =
> &rzg1_du_r8a7743_info },
> > { .compatible = "renesas,du-r8a7745", .data =
> &rzg1_du_r8a7745_info },
> > { .compatible = "renesas,du-r8a77470", .data =
> > &rzg1_du_r8a77470_info },
> > + { .compatible = "renesas,du-r8a774a1", .data =
> &rcar_du_r8a7796_info
> > +},
> > { .compatible = "renesas,du-r8a774c0", .data =
> &rcar_du_r8a774c0_info },
> > { .compatible = "renesas,du-r8a7779", .data = &rcar_du_r8a7779_info
> },
> > { .compatible = "renesas,du-r8a7790", .data = &rcar_du_r8a7790_info
> > },
> >
