Hi Dong-san, On Thu, Apr 11, 2019 at 04:54:10PM +0900, Cao Van Dong wrote: > Add ether node to dtsi for Ether support on the RZ/G1C (r8a77470) SoC. > > Signed-off-by: Cao Van Dong <cv-dong@xxxxxxxxxxx> > --- > arch/arm/boot/dts/r8a77470.dtsi | 14 ++++++++++++++ > 1 file changed, 14 insertions(+) > > diff --git a/arch/arm/boot/dts/r8a77470.dtsi b/arch/arm/boot/dts/r8a77470.dtsi > index 9fc9f6a..ae1dba0 100644 > --- a/arch/arm/boot/dts/r8a77470.dtsi > +++ b/arch/arm/boot/dts/r8a77470.dtsi > @@ -1099,6 +1099,20 @@ > dma-channels = <13>; > }; > > + ether: ethernet@ee700000 { Nodes should be sorted by 1. Bus address 2. IP block type So ethernet@ee700000 should go after sd@ee100000. Otherwise this patch looks good to me. > + compatible = "renesas,ether-r8a77470", > + "renesas,rcar-gen2-ether"; > + reg = <0 0xee700000 0 0x400>; > + interrupts = <GIC_SPI 162 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&cpg CPG_MOD 813>; > + power-domains = <&sysc R8A77470_PD_ALWAYS_ON>; > + resets = <&cpg 813>; > + phy-mode = "rmii"; > + #address-cells = <1>; > + #size-cells = <0>; > + status = "disabled"; > + }; > + > sdhi0: sd@ee100000 { > compatible = "renesas,sdhi-r8a77470", > "renesas,rcar-gen2-sdhi"; > -- > 2.7.4 >