Dear Morimoto-san,
On 2019/04/10 9:37, Kuninori Morimoto wrote:
Hi Dong-san
Thank you for your patch
+ rcar_sound: sound@ec500000 {
+ /*
+ * #sound-dai-cells is required
+ *
+ * Single DAI : #sound-dai-cells = <0>; <&rcar_sound>;
+ * Multi DAI : #sound-dai-cells = <1>; <&rcar_sound N>;
+ */
+ compatible = "renesas,rcar_sound-r8a77470",
+ "renesas,rcar_sound-gen2";
+ reg = <0 0xec500000 0 0x1000>, /* SCU */
+ <0 0xec5a0000 0 0x100>, /* ADG */
+ <0 0xec540000 0 0x1000>, /* SSIU */
+ <0 0xec541000 0 0x280>, /* SSI */
+ <0 0xec740000 0 0x200>; /* Audio DMAC peri peri */
+ reg-names = "scu", "adg", "ssiu", "ssi", "audmapp";
I don't have r8a77470 datasheet, but does it have *extended* Audio DMAC peri peri
address (= 0xec760000) ? If it has, please use it instead of normal address (= 0xec740000).
+ rcar_sound,ssi {
+ ssi0: ssi-0 {
+ interrupts = <GIC_SPI 370 IRQ_TYPE_LEVEL_HIGH>;
+ dmas = <&audma0 0x01>, <&audma0 0x02>,
+ <&audma0 0x15>, <&audma0 0x16>;
+ dma-names = "rx", "tx", "rxu", "txu";
+ };
Please add ssiu.
And then, ssi doesn't need "rxu" and "txu" anymore.
These can be good help for you.
0ec8e0a879b8d7eacbfbed9a7face8f97f9493a8
("arm64: dts: renesas: r8a7795: remove BUSIF0 settings from rcar_sound,ssi")
da90dd849dc22e920388d18a0f877366bd4d2b7f
("arm64: dts: renesas: r8a7795: add SSIU support for sound")
BTW, this patch-set is including SoC only.
Do you have plan to post board support patch after this ?
In other words, did you test these ?
Thanks for your feedback and help!
I will create a separate patch (add
rcar_sound-r8a77470toDocumentation/../sound/renesas,rsnd.txt)
and update this patch in version 2.
Thank you,
Dong
Thank you for your help !!
Best regards
---
Kuninori Morimoto
