Hi Biju-san, Thank you for the patch! > From: Biju Das, Sent: Wednesday, April 3, 2019 7:29 PM > > This patch adds support for r8a77470 (RZ/G1C). We can reuse this driver for > initializing timing/interrupt generation registers. > > Signed-off-by: Biju Das <biju.das@xxxxxxxxxxxxxx> > --- It seems good to me. However, since Fabrizio-san and I have submitted patch(es) for the driver around the same time, I'm confusing how to handle this patch. < At March 1, 2019, 11:05 a.m. UTC > https://patchwork.kernel.org/patch/10834975/ - Kishon-san said "merged" at April 1, but I mentioned this patch breaks R-Car D3. - I checked today's his repo, but it doesn't seem to merge it. - I don't get any feedback. < At April 1, 2019, 12:01 p.m. UTC > https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=99561 - Got Simon-san and Fabrizio-san's review. and then, < At April 3, 2019, 10:28 a.m. UTC > https://patchwork.kernel.org/patch/10883265/ > V1-->V2 > * Incorporated shimoda-san's review comment > Ref: https://patchwork.kernel.org/patch/10655855/ > --- > drivers/phy/renesas/Kconfig | 2 +- > drivers/phy/renesas/phy-rcar-gen3-usb2.c | 19 ++++++++++++++++++- > 2 files changed, 19 insertions(+), 2 deletions(-) > > diff --git a/drivers/phy/renesas/Kconfig b/drivers/phy/renesas/Kconfig > index e340a92..961ccb1 100644 > --- a/drivers/phy/renesas/Kconfig > +++ b/drivers/phy/renesas/Kconfig > @@ -19,7 +19,7 @@ config PHY_RCAR_GEN3_PCIE > config PHY_RCAR_GEN3_USB2 > tristate "Renesas R-Car generation 3 USB 2.0 PHY driver" > depends on ARCH_RENESAS > - depends on EXTCON > + depends on EXTCON || ARCH_R8A77470 If EXTCON=m, build error might happen like below. https://marc.info/?l=linux-renesas-soc&m=154220057305761&w=2 Is it enough about "depends on EXTCON || !EXTCON" for your environment? Best regards, Yoshihiro Shimoda
