Re: [PATCH v2 3/3] spi: sh-msiof: Add reset of registers before starting transfer

[Wolfram Sang <wsa@xxxxxxxxxxxxx>]

On Tue, Apr 02, 2019 at 04:40:23PM +0200, Geert Uytterhoeven wrote:
> In accordance with hardware specification Ver 1.0, reset register
> transmission / reception setting before transfer.
> 
> Signed-off-by: Hiromitsu Yamasaki <hiromitsu.yamasaki.ym@xxxxxxxxxxx>
> [geert: Use readl_poll_timeout_atomic()]
> Signed-off-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>

Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>

Minor nit:

> +	/* reset registers */
> +	sh_msiof_spi_reset_regs(p);

I don't think this comment adds value.

Attachment: signature.asc
Description: PGP signature