Hi Alan, Thanks for the feedback. > Subject: Re: [PATCH 04/12] usb: host: ehci-r8a77470: Add EHCI support for > Renesas RZ/G1C devices > > On Mon, 1 Apr 2019, Biju Das wrote: > > > This patch adds the glue code required to ensure the on-chip EHCI > > controller works on RZ/G1C(a.k.a R8A77470) SoC's from Renesas. > > You should explain what this new glue code does. And why is it needed? Glue code initializes following registers on the host 1) initializing interrupt enable 2) OVC detection timer 3) suspend/ resume timer register Without glue code, interrupt generation is disabled. > Can't you use the existing ehci-platform driver instead? > This driver is almost similar to generic ehci-platform except that it needs to do some platform initialization as mentioned above. If I am correct, we cannot do any platform initialization in generic code. The reason for the new driver is because of the below discussion https://patchwork.kernel.org/patch/10655853/ regards, Biju
