Hi Geert, On 01 April 2019 10:00, Geert Uytterhoeven wrote: > Subject: Re: [PATCH 1/2] rtc: da9063: set range > > Hi Wolfram, > > On Mon, Apr 1, 2019 at 10:43 AM Wolfram Sang <wsa@xxxxxxxxxxxxx> wrote: > > On Thu, Mar 21, 2019 at 11:15:56AM +0100, Alexandre Belloni wrote: > > > The DA9062 and DA9063 have a year register that can go up to 0x3F. > > > > > > Signed-off-by: Alexandre Belloni <alexandre.belloni@xxxxxxxxxxx> > > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > > > > I couldn't test the upper limit (DA9063 hooked to a 32bit system here), > > but lower limit works and RTC in general works. > > BTW, does the RTC alarm interrupt work for you? As far as I can tell, there are no RTC alarm regressions. I am using an i.MX6Q board and with an unmodified v5.1-rc1 kernel, for the alarms, I see everything working okay WITHOUT Alexandre's patches ... Then, WITH Alexandre's patches ... - https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=05e4ffeadecaa6f501218504b86a6cec89202bd9 - https://git.kernel.org/pub/scm/linux/kernel/git/abelloni/linux.git/commit/?h=rtc-next&id=da44e0eb7ec6853b5d20faba7dc34c48e4bb35c7 ... applied to v5.1-rc1, and with the same set-up, [ 2.027144] da9063 1-0058: Device detected (chip-ID: 0x61, var-ID: 0x60) [ 2.483699] da9063-rtc da9063-rtc: DMA mask not set [ 2.523279] da9063-rtc da9063-rtc: registered as rtc0 Linux test 5.1.0-rc1 #1 SMP Mon Apr 1 13:05:32 BST 2019 armv7l GNU/Linux [...] [PASS] Setting the current date and time from the da9063-rtc da9063-rtc as 2000-01-01 00:00:00 [PASS] Setting the alarm date and time from the da9063-rtc da9063-rtc as 2000-01-01 00:00:05 (+5 secs into the future) [PASS] Setting the listener on da9063-rtc da9063-rtc then waiting for elapsed timeout of 15 seconds... [PASS] The alarm was triggered on da9063-rtc da9063-rtc within the expected time and the alarm happened at 2000-01-01 00:00:05 [PASS] Setting the current date and time from the da9063-rtc da9063-rtc as 2000-01-01 00:00:00 [PASS] Setting the alarm date and time from the da9063-rtc da9063-rtc as 2000-01-01 00:00:15 (+15 secs into the future) [PASS] Setting the listener on da9063-rtc da9063-rtc then waiting for elapsed timeout of 25 seconds... [PASS] The alarm was triggered on da9063-rtc da9063-rtc within the expected time and the alarm happened at 2000-01-01 00:00:15 > cat /proc/interrupts | grep da90 247: 2 0 0 0 gpio-mxc 11 Level da9063-irq 305: 0 0 2 0 da9063-irq 1 Level ALARM I get an identical result. So as far as I can tell, there are no RTC alarm regressions. Tested-by: Steve Twiss <stwiss.opensource@xxxxxxxxxxx> Regards, Steve
