Re: [PATCH v2] serial: sh-sci: Support for HSCIF RX sampling point adjustment

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> On March 29, 2019 at 10:56 AM Geert Uytterhoeven <geert@xxxxxxxxxxxxxx> wrote:
> 
> 
> Hi Uli,
> 
> On Fri, Mar 29, 2019 at 10:46 AM Ulrich Hecht <uli@xxxxxxxx> wrote:
> > Reviewing the code, I have found another potential issue: the SRR (sampling rate) value is not validated; only values from 7 to 31 are permissible, according to the datasheet. The values in the debug output above would be fine, though.
> 
> Isn't that handled by
> 
>                 .sampling_rate_mask = SCI_SR_RANGE(8, 32),
> 
> ?

Having crawled through the related macros, I can confirm that it is.

CU
Uli



[Index of Archives]     [Linux Samsung SOC]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux