On Mon, Mar 25, 2019 at 12:40:56PM +0100, marek.vasut@xxxxxxxxx wrote: > From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > > Replace macros using constants with BIT()s instead, no functional change. > > Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx> > Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx> > Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx> > Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx> > Cc: linux-renesas-soc@xxxxxxxxxxxxxxx > To: linux-pci@xxxxxxxxxxxxxxx > Reviewed-by: Wolfram Sang <wsa+renesas@xxxxxxxxxxxxxxxxxxxx> > Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx> > --- > V2: Bundle this patch with other cleanups before resending > V3: Add Wolfram's R-B > V4: Add Geert's R-B > --- > drivers/pci/controller/pcie-rcar.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Hi Marek, I assume this series makes: https://patchwork.ozlabs.org/patch/1053779/ https://patchwork.ozlabs.org/patch/1057454/ obsolete, please let me know and I will drop them from the PCI patches queue, I will get to this series later for v5.2. Thanks, Lorenzo > > diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c > index c8febb009454..5b8736f0cd6b 100644 > --- a/drivers/pci/controller/pcie-rcar.c > +++ b/drivers/pci/controller/pcie-rcar.c > @@ -46,14 +46,14 @@ > > /* Transfer control */ > #define PCIETCTLR 0x02000 > -#define CFINIT 1 > +#define CFINIT BIT(0) > #define PCIETSTR 0x02004 > -#define DATA_LINK_ACTIVE 1 > +#define DATA_LINK_ACTIVE BIT(0) > #define PCIEERRFR 0x02020 > #define UNSUPPORTED_REQUEST BIT(4) > #define PCIEMSIFR 0x02044 > #define PCIEMSIALR 0x02048 > -#define MSIFE 1 > +#define MSIFE BIT(0) > #define PCIEMSIAUR 0x0204c > #define PCIEMSIIER 0x02050 > > -- > 2.20.1 >
