Re: [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Wolfram Sang <wsa@xxxxxxxxxxxxx>
Subject: Re: [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values
From: Marek Vasut <marek.vasut@xxxxxxxxx>
Date: Sat, 23 Mar 2019 02:28:08 +0100
Cc: linux-pci@xxxxxxxxxxxxxxx, Marek Vasut <marek.vasut+renesas@xxxxxxxxx>, Geert Uytterhoeven <geert+renesas@xxxxxxxxx>, Phil Edworthy <phil.edworthy@xxxxxxxxxxx>, Simon Horman <horms+renesas@xxxxxxxxxxxx>, linux-renesas-soc@xxxxxxxxxxxxxxx
In-reply-to: <20190322084119.GI1005@kunai>
Openpgp: preference=signencrypt
References: <20190322023844.18574-1-marek.vasut@gmail.com> <20190322023844.18574-3-marek.vasut@gmail.com> <20190322084119.GI1005@kunai>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 3/22/19 9:41 AM, Wolfram Sang wrote:
> 
>> @@ -508,7 +509,7 @@ static void phy_write_reg(struct rcar_pcie *pcie,
>>  				 unsigned int rate, unsigned int addr,
>>  				 unsigned int lane, unsigned int data)
> 
> What about converting 'addr' and 'data' here? Other than those, I didn't
> find other candidates in this driver.

Sure, fixed.

-- 
Best regards,
Marek Vasut

References:
- [PATCH V2 1/6] PCI: rcar: Clean up remaining macros defining bits
  - From: marek . vasut
- [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values
  - From: marek . vasut
- Re: [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values
  - From: Wolfram Sang

Prev by Date: [PATCH V3 6/6] PCI: rcar: Fix 64bit MSI message address handling
Next by Date: Re: [PATCH V2 6/6] PCI: rcar: Allow 64bit MSI addresses
Previous by thread: Re: [PATCH V2 3/6] PCI: rcar: Replace various variable types with unsigned ones for register values
Next by thread: [PATCH V2 4/6] PCI: rcar: Replace (8 * n) with (n << 3)
Index(es):
- Date
- Thread

[Index of Archives] [Linux Samsung SOC] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]