Hi Marek,
On Sun, Mar 17, 2019 at 1:06 AM <marek.vasut@xxxxxxxxx> wrote:
> From: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
>
> Replace unsigned long with u32 type for variables holding
> register values, since the registers are 32bit. Note that
> rcar_pcie_msi_irq() still uses unsigned long because both
> find_first_bit() and __fls() require unsigned long as an
> argument.
>
> Signed-off-by: Marek Vasut <marek.vasut+renesas@xxxxxxxxx>
> Cc: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
> Cc: Phil Edworthy <phil.edworthy@xxxxxxxxxxx>
> Cc: Simon Horman <horms+renesas@xxxxxxxxxxxx>
> Cc: Wolfram Sang <wsa@xxxxxxxxxxxxx>
> Cc: linux-renesas-soc@xxxxxxxxxxxxxxx
> To: linux-pci@xxxxxxxxxxxxxxx
> ---
> drivers/pci/controller/pcie-rcar.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
> index 1408c8aa758b..857d88fd03d5 100644
> --- a/drivers/pci/controller/pcie-rcar.c
> +++ b/drivers/pci/controller/pcie-rcar.c
> @@ -169,7 +169,7 @@ enum {
>
> static void rcar_rmw32(struct rcar_pcie *pcie, int where, u32 mask, u32 data)
> {
> - int shift = 8 * (where & 3);
> + u32 shift = 8 * (where & 3);
shift is not a register value, so IMHO the original type is fine (the "int"
comes from the pci_ops API, BTW).
> u32 val = rcar_pci_read_reg(pcie, where & ~3);
>
> val &= ~(mask << shift);
> @@ -179,7 +179,7 @@ static void rcar_rmw32(struct rcar_pcie *pcie, int where, u32 mask, u32 data)
>
> static u32 rcar_read_conf(struct rcar_pcie *pcie, int where)
> {
> - int shift = 8 * (where & 3);
> + u32 shift = 8 * (where & 3);
Likewise
> u32 val = rcar_pci_read_reg(pcie, where & ~3);
>
> return val >> shift;
> @@ -190,7 +190,7 @@ static int rcar_pcie_config_access(struct rcar_pcie *pcie,
> unsigned char access_type, struct pci_bus *bus,
> unsigned int devfn, int where, u32 *data)
> {
> - int dev, func, reg, index;
> + u32 dev, func, reg, index;
reg is the only register value, isn't it?
>
> dev = PCI_SLOT(devfn);
> func = PCI_FUNC(devfn);
> @@ -508,7 +508,7 @@ static void phy_write_reg(struct rcar_pcie *pcie,
> unsigned int rate, unsigned int addr,
> unsigned int lane, unsigned int data)
> {
> - unsigned long phyaddr;
> + u32 phyaddr;
>
> phyaddr = WRITE_CMD |
> ((rate & 1) << RATE_POS) |
> @@ -1116,7 +1116,7 @@ static int rcar_pcie_probe(struct platform_device *pdev)
> {
> struct device *dev = &pdev->dev;
> struct rcar_pcie *pcie;
> - unsigned int data;
> + u32 data;
> int err;
> int (*phy_init_fn)(struct rcar_pcie *);
> struct pci_host_bridge *bridge;
For the last two changes:
Reviewed-by: Geert Uytterhoeven <geert+renesas@xxxxxxxxx>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
