On Wed, Mar 13, 2019 at 01:14:33PM +0100, Geert Uytterhoeven wrote: > Hi Simon, > > On Wed, Mar 13, 2019 at 11:58 AM Simon Horman > <horms+renesas@xxxxxxxxxxxx> wrote: > > this short series supports S2RAM on R-Car E3 (r8a77990) / Ebisu by: > > > > * Upporting description of BD9571 PMIC in DT from BSP v3.9.2 > > * Adding DDR0 backpo power configuration to that description > > > > Simon Horman (1): > > arm64: dts: renesas: ebisu: Add PMIC DDR0 Backup Power config > > > > Takeshi Kihara (1): > > arm64: dts: renesas: r8a77990-ebisu: Add BD9571 PMIC > > > > arch/arm64/boot/dts/renesas/r8a77990-ebisu.dts | 27 ++++++++++++++++++++++++++ > > 1 file changed, 27 insertions(+) > > > > Tested using the following procedure with patches applied > > on renesas-devel-20190308-v5.0 and kernel compiled using > > renesas_defconfig. > > > > 1. Add no_console_suspend to kernel command line > > 2. Boot system > > 3. # echo on > /sys/bus/i2c/drivers/bd9571mwv/8-0030/bd9571mwv-regulator.0.auto/backup_mode > > 4. Toggle SW23 to off position > > I think one step is missing here: > > # echo mem > /sys/power/state Yes, indeed. > > System suspends with following displayed on console > > > > [ 91.486537] PM: suspend entry (deep) > > [ 91.490281] PM: Syncing filesystems ... done. > > [ 91.500460] Freezing user space processes ... (elapsed 0.001 seconds) > > done. > > [ 91.509392] OOM killer disabled. > > [ 91.512679] Freezing remaining freezable tasks ... (elapsed 0.001 > > seconds) done. > > [ 91.531235] ravb e6800000.ethernet eth0: Link is Down > > [ 91.670747] Disabling non-boot CPUs ... > > [ 91.676106] CPU1: shutdown > > [ 91.678932] psci: CPU1 killed. > > > > 5. Toggle SW23 to on position > > System resumes with the following output to the console > > Gr{oetje,eeting}s, > > Geert > > -- > Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx > > In personal conversations with technical people, I call myself a hacker. But > when I'm talking to journalists I just say "programmer" or something like that. > -- Linus Torvalds >